fix: L1 NFT attributes #3474
Merged
fix: L1 NFT attributes #3474
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dessaya
approved these changes
Jul 17, 2024
| @@ -14,10 +14,10 @@ type IRC27NFTMetadata struct { | |||
| Royalties map[string]float32 `json:"royalties,omitempty"` | |||
| IssuerName string `json:"issuerName,omitempty"` | |||
| Description string `json:"description,omitempty"` | |||
| Attributes string `json:"attributes,omitempty"` | |||
| Attributes []interface{} `json:"attributes,omitempty"` | |||
There was a problem hiding this comment.
Nit: []any is shorter :)
Also: json.RawMessage does not work for this case?
There was a problem hiding this comment.
ah, I had auto-merge enabled :/ . Good points tho, thanks 👍
json.RawMessage unfortunately makes this test fail because it strips the whitespace:
- Attributes: (json.RawMessage) (len=37) {
- 00000000 7b 22 74 72 61 69 74 5f 74 79 70 65 22 3a 20 22 |{"trait_type": "|
- 00000010 46 6f 6f 22 2c 20 22 76 61 6c 75 65 22 3a 20 22 |Foo", "value": "|
- 00000020 42 61 72 22 7d |Bar"}|
+ Attributes: (json.RawMessage) (len=34) {
+ 00000000 7b 22 74 72 61 69 74 5f 74 79 70 65 22 3a 22 46 |{"trait_type":"F|
+ 00000010 6f 6f 22 2c 22 76 61 6c 75 65 22 3a 22 42 61 72 |oo","value":"Bar|
+ 00000020 22 7d |"}|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
getTokenURIcurrently does not correctly return the attributes from L1 NFTs metadata.due to an array of mappings to arbitrary types (JSON) being very hard to represent in Solidity, I opted to remove the
attributesfield from thegetIRC27NFTDatafunction.